compability with Django 1.10 #29

Merged
merged 1 commit into from Aug 5, 2016

Projects

None yet

7 participants

@Arany
Contributor
Arany commented May 17, 2016

get_urls function:

  • Using list instead patterns function
  • importing Django javascript_catalog instead of using string name
@Arany Arany compability with Django 1.10
get_urls function:
* Using list instead patterns function
* importing Django javascript_catalog instead of using string name
2edb72d
@kjg531
kjg531 commented Jun 12, 2016

+1 please merge this!

@qnub
qnub commented Jul 20, 2016

@tabo have you checked GitHub?

@SalahAdDin

Solve this these bugs?

/home/salahaddin/Proyectos/demo-oscar/lib/python3.5/site-packages/treebeard/admin.py:62: RemovedInDjango110Warning: Support for string view arguments to url() is deprecated and will be removed in Django 1.10 (got django.views.i18n.javascript_catalog). Pass the callable instead.
  {'packages': ('treebeard',)}),

/home/salahaddin/Proyectos/demo-oscar/lib/python3.5/site-packages/treebeard/admin.py:62: RemovedInDjango110Warning: django.conf.urls.patterns() is deprecated and will be removed in Django 1.10. Update your urlpatterns to be a list of django.conf.urls.url() instances instead.
  {'packages': ('treebeard',)}),
@Arany
Contributor
Arany commented Aug 4, 2016

@SalahAdDin: Yes, that is what the pullrequest is for.
@tabo: Now Django 1.10 is out and django-treebeard is not any more compatible with it. Please check this PR out..

@kierun
kierun commented Aug 5, 2016

Django 1.10.0 has been out for a little while now. It would be nice for this to be merged…

@tabo tabo merged commit e739215 into django-treebeard:master Aug 5, 2016
@tabo
Member
tabo commented Aug 5, 2016

Merged! Thanks for the PR!

@kierun
kierun commented Aug 5, 2016

Now, that is awesome! I was just writing a note in our internal mantis that I could not update because of this… Thank you very much.

@kierun
kierun commented Aug 5, 2016

Quick question, are you planning to release it a new version soon? Just so I know if I should run the latest bleeding edge or wait for a few hours. ;)

@tabo
Member
tabo commented Aug 5, 2016

Yep! Will work on that during the weekend :)

@kierun
kierun commented Aug 5, 2016

I noticed there is still a bug there: In treebeard/admin.py,

from django.conf.urls import pattern, url

should read:

from django.conf.urls import url

Do you want me to make a pull request or is it way too trivial for that?

@kcolton
Contributor
kcolton commented Sep 11, 2016

@tabo @kierun Thanks for the updates. That 1 last line, regardless of how entered would be appreciated. We are running off a fork with that 1 change just to get 1.10 going. :) Cheers and thanks for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment