New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to_string import fixed #4

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@igniteflow

igniteflow commented Feb 26, 2013

Error:

In [1]: from django_webtest import WebTest

ImportError Traceback (most recent call last)
in ()
----> 1 from django_webtest import WebTest

/home/vagrant/.virtualenvs/gsa/lib/python2.6/site-packages/django_webtest/init.py in ()
16
17 from webtest import TestApp
---> 18 from webtest.compat import to_string
19
20 from django_webtest.response import DjangoWebtestResponse

ImportError: cannot import name to_string

I have changed the import to:

from webtest.lint import to_string

seems to fix the issue

@kmike

This comment has been minimized.

Show comment
Hide comment
@kmike

kmike Feb 27, 2013

Member

Hi Phil,

I can't merge this change as-is because it would break backwards compatibility with WebTest < 2.0. There is an another pull request, https://bitbucket.org/kmike/django-webtest/pull-request/4/fix-import-error-with-webtest-20/diff , but I can't merge it either, because it uses six and six is not a dependency of WebTest 1.4.3 so it also would break backwards compatibility.

I'll fix it by introducing django_webtest.compat soon.

Member

kmike commented Feb 27, 2013

Hi Phil,

I can't merge this change as-is because it would break backwards compatibility with WebTest < 2.0. There is an another pull request, https://bitbucket.org/kmike/django-webtest/pull-request/4/fix-import-error-with-webtest-20/diff , but I can't merge it either, because it uses six and six is not a dependency of WebTest 1.4.3 so it also would break backwards compatibility.

I'll fix it by introducing django_webtest.compat soon.

@kmike kmike closed this in 84725b8 Feb 27, 2013

@kmike

This comment has been minimized.

Show comment
Hide comment
@kmike

kmike Feb 27, 2013

Member

Thanks for the pull request! The issue is fixed in django-webtest 1.5.7.

Member

kmike commented Feb 27, 2013

Thanks for the pull request! The issue is fixed in django-webtest 1.5.7.

@igniteflow

This comment has been minimized.

Show comment
Hide comment
@igniteflow

igniteflow Feb 27, 2013

Thanks for the update!

On 27 February 2013 08:56, Mikhail Korobov notifications@github.com wrote:

Thanks for the pull request! The issue is fixed in django-webtest 1.5.7.


Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-14163206
.

igniteflow commented Feb 27, 2013

Thanks for the update!

On 27 February 2013 08:56, Mikhail Korobov notifications@github.com wrote:

Thanks for the pull request! The issue is fixed in django-webtest 1.5.7.


Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-14163206
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment