Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.5 Django <2.3 dependency #1026

Closed
kaprests opened this issue Feb 18, 2020 · 2 comments
Closed

v0.5 Django <2.3 dependency #1026

kaprests opened this issue Feb 18, 2020 · 2 comments

Comments

@kaprests
Copy link

@kaprests kaprests commented Feb 18, 2020

When using pipenv, and trying to install django >= 2.3 with django-wiki installed, I am unable to lock dependencies due to django-wiki requireing django<=2.3 even though it supposedly supports django 3.0. Is there perhaps some issue with how django-wiki communicates its dependencies to pipenv?

The issue does not arise with django-wiki verison 0.6b1.

@slinkymanbyday

This comment has been minimized.

Copy link

@slinkymanbyday slinkymanbyday commented Feb 18, 2020

@benjaoming
as 0.5.x doesn't actually support django 3 due to locked dependencies, should that be removed from the readme?

@kaprests
for proper django3 support you will need 0.6b1 and above due to 0.5 linking to the older versions of dependencies which did not support django3

benjaoming added a commit to benjaoming/django-wiki that referenced this issue Feb 18, 2020
@benjaoming

This comment has been minimized.

Copy link
Member

@benjaoming benjaoming commented Feb 18, 2020

Really good point that you raise @kaprests - we left this dangling, as the support wasn't actually completed until months after it was implemented. We were stalled, waiting for a new sorl-thumbnail release and meanwhile committed so many things to master, that 0.6 became necessary :)

Thanks for raising this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.