New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest & Tox improvements #644

Closed
benjaoming opened this Issue Jun 7, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@benjaoming
Member

benjaoming commented Jun 7, 2017

  • Get rid of runtests.py, too much overhead
  • Make it possible to run py.test directly on the current virtualenv
  • Tox should accept a positional argument of a specific test to run
  • Tox.ini should say usedevelop = false because it's dangerous to assume the dev environment is the same as the distributed one.

@benjaoming benjaoming self-assigned this Jun 7, 2017

azaghal added a commit to azaghal/django-wiki that referenced this issue Feb 14, 2018

Fix running tests without tox and clean-up/refactor requirements hand…
…ling for tests/development (issue django-wiki#644):

- Updated package setup to define cleanly all test requirements within
  it.
- Updated package setup to provide ability to install specific set of
  development/testing/lint testing requirements.
- Removed explicit non-leaf dependencies from test requirements.
- Updated leaf dependencies to target more specific release (current
  stable in most cases). This is primarily fixing versions to specific
  minor release.
- Removed explicit list of dependencies from the tox configuration
  file. Use the dependencies from setup.py instead.
- Updated package setup to support running simple python setup.py test
  for running the tests.
- Updated flake8 configuration to exclude all the standard build
  artefacts, as well as testproject.
- It should be possible to directly run pytest for testing now, as
  well as flake8.
- Updated development documentation centering around how to run tests
  and install dependencies for tests.
- Expanded slightly the development documentation hints for running
  specific tests.

azaghal added a commit to azaghal/django-wiki that referenced this issue Feb 14, 2018

Remove runtests.py and run pytest directly (issue django-wiki#644):
- Removed the runtests.py script.
- Updated manifest file to not include the removed script.
- Updated documentation to reference to direct use of the pytest
  command.
- Updated tox configuration to run pytest directly.
- Added documentation for the SELENIUM_SHOW_BROWSER environment
  variable.
- Updated testing documentation to mention that Xvfb must be available
  on the system as well for runing Selenium tests.

azaghal added a commit to azaghal/django-wiki that referenced this issue Feb 14, 2018

Set usedevelop to false in tox configuration file (issue django-wiki#644
):

- Set the usedevelop value to false, since it is considered dangerous
  to assume that the development environment is the same as the
  distributed one (same set of files etc may not be present).

azaghal added a commit to azaghal/django-wiki that referenced this issue Feb 14, 2018

Fix running tests without tox and clean-up/refactor requirements hand…
…ling for tests/development (issue django-wiki#644):

- Updated package setup to define cleanly all test requirements within
  it.
- Updated package setup to provide ability to install specific set of
  development/testing/lint testing requirements.
- Removed explicit non-leaf dependencies from test requirements.
- Updated leaf dependencies to target more specific release (current
  stable in most cases). This is primarily fixing versions to specific
  minor release.
- Removed explicit list of dependencies from the tox configuration
  file. Use the dependencies from setup.py instead.
- Updated package setup to support running simple python setup.py test
  for running the tests.
- Updated flake8 configuration to exclude all the standard build
  artefacts, as well as testproject.
- It should be possible to directly run pytest for testing now, as
  well as flake8.
- Updated development documentation centering around how to run tests
  and install dependencies for tests.
- Expanded slightly the development documentation hints for running
  specific tests.

azaghal added a commit to azaghal/django-wiki that referenced this issue Feb 14, 2018

Remove runtests.py and run pytest directly (issue django-wiki#644):
- Removed the runtests.py script.
- Updated manifest file to not include the removed script.
- Updated documentation to reference to direct use of the pytest
  command.
- Updated tox configuration to run pytest directly.
- Added documentation for the SELENIUM_SHOW_BROWSER environment
  variable.
- Updated testing documentation to mention that Xvfb must be available
  on the system as well for runing Selenium tests.

azaghal added a commit to azaghal/django-wiki that referenced this issue Feb 14, 2018

Set usedevelop to false in tox configuration file (issue django-wiki#644
):

- Set the usedevelop value to false, since it is considered dangerous
  to assume that the development environment is the same as the
  distributed one (same set of files etc may not be present).

azaghal added a commit to azaghal/django-wiki that referenced this issue Feb 14, 2018

Fix running tests without tox and clean-up/refactor requirements hand…
…ling for tests/development (issue django-wiki#644):

- Updated package setup to define cleanly all test requirements within
  it.
- Updated package setup to provide ability to install specific set of
  development/testing/lint testing requirements.
- Removed explicit non-leaf dependencies from test requirements.
- Updated leaf dependencies to target more specific release (current
  stable in most cases). This is primarily fixing versions to specific
  minor release.
- Removed explicit list of dependencies from the tox configuration
  file. Use the dependencies from setup.py instead.
- Updated package setup to support running simple python setup.py test
  for running the tests.
- Updated flake8 configuration to exclude all the standard build
  artefacts, as well as testproject.
- It should be possible to directly run pytest for testing now, as
  well as flake8.
- Updated development documentation centering around how to run tests
  and install dependencies for tests.
- Expanded slightly the development documentation hints for running
  specific tests.

azaghal added a commit to azaghal/django-wiki that referenced this issue Feb 14, 2018

Remove runtests.py and run pytest directly (issue django-wiki#644):
- Removed the runtests.py script.
- Updated manifest file to not include the removed script.
- Updated documentation to reference to direct use of the pytest
  command.
- Updated tox configuration to run pytest directly.
- Added documentation for the SELENIUM_SHOW_BROWSER environment
  variable.
- Updated testing documentation to mention that Xvfb must be available
  on the system as well for runing Selenium tests.

azaghal added a commit to azaghal/django-wiki that referenced this issue Feb 14, 2018

Set usedevelop to false in tox configuration file (issue django-wiki#644
):

- Set the usedevelop value to false, since it is considered dangerous
  to assume that the development environment is the same as the
  distributed one (same set of files etc may not be present).

azaghal added a commit to azaghal/django-wiki that referenced this issue Feb 14, 2018

benjaoming added a commit that referenced this issue Feb 15, 2018

Merge pull request #781 from azaghal/pytest-tox-improvements-issue-644
Improved test dependency handling, removal of wrapper testing script, and fixes for running pytest directly (issue #644)
@benjaoming

This comment has been minimized.

Member

benjaoming commented Feb 15, 2018

@azaghal has totally nailed this issue! Thanks!

@benjaoming benjaoming closed this Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment