Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sorl-thumbnail and django-mptt for Django 3.0 support #1019

Merged
merged 8 commits into from Feb 8, 2020

Conversation

@benjaoming
Copy link
Member

benjaoming commented Feb 3, 2020

Fixes #992

(NB django-mptt upgrade is unverified)

@slinkymanbyday

This comment has been minimized.

Copy link

slinkymanbyday commented Feb 6, 2020

I have done some work on this. the following branch on my repo should pass all tests:
https://github.com/slinkymanbyday/django-wiki/tree/django-3-dependancies

happy to create a PR, or for you to update your PR with my changes.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 8, 2020

Codecov Report

Merging #1019 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1019   +/-   ##
=======================================
  Coverage   82.52%   82.52%           
=======================================
  Files         109      110    +1     
  Lines        4573     4573           
=======================================
  Hits         3774     3774           
  Misses        799      799
Impacted Files Coverage Δ
src/wiki/plugins/attachments/forms.py 61.68% <ø> (-1.39%) ⬇️
src/wiki/migrations/0003_mptt_upgrade.py 100% <100%> (ø)
src/wiki/plugins/globalhistory/views.py 100% <0%> (ø) ⬆️
src/wiki/core/paginator.py 100% <0%> (ø) ⬆️
src/wiki/templatetags/wiki_tags.py 100% <0%> (ø) ⬆️
src/wiki/plugins/notifications/views.py 100% <0%> (ø) ⬆️
src/wiki/plugins/links/views.py 0% <0%> (ø) ⬆️
src/wiki/sites.py 98.76% <0%> (ø) ⬆️
src/wiki/plugins/editsection/views.py 92.59% <0%> (ø) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a550502...33da457. Read the comment docs.

@benjaoming

This comment has been minimized.

Copy link
Member Author

benjaoming commented Feb 8, 2020

Thanks so much @slinkymanbyday

Going to see how your fixes for the test case and the field order can be added 🎉

benjaoming added a commit to benjaoming/django-wiki that referenced this pull request Feb 8, 2020
@benjaoming benjaoming force-pushed the benjaoming:bump-sorl branch from 96c32f5 to 922ef13 Feb 8, 2020
@benjaoming benjaoming merged commit 36ffb7d into django-wiki:master Feb 8, 2020
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.