New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow plugins to modify Bleach tag lists #700

Merged
merged 2 commits into from Oct 9, 2017

Conversation

Projects
None yet
2 participants
@jenda1
Contributor

jenda1 commented Oct 1, 2017

some plugins already needs modify the bleach tags whitelist (plugins/images). This changeset add two options to a plugin class:

  • html_whitelist - list of http tags to be added to bleach whitelist
  • html_attributes - dictionary of http attributes to be added to bleach whitelist in the format
    http tag : [ allowed attributes ]
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 9, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (master@dc8357c). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #700   +/-   ##
=========================================
  Coverage          ?   69.98%           
=========================================
  Files             ?       89           
  Lines             ?     4425           
  Branches          ?        0           
=========================================
  Hits              ?     3097           
  Misses            ?     1328           
  Partials          ?        0
Impacted Files Coverage Δ
src/wiki/core/plugins/registry.py 95.45% <100%> (ø)
src/wiki/core/markdown/__init__.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc8357c...75e11c3. Read the comment docs.

codecov bot commented Oct 9, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (master@dc8357c). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #700   +/-   ##
=========================================
  Coverage          ?   69.98%           
=========================================
  Files             ?       89           
  Lines             ?     4425           
  Branches          ?        0           
=========================================
  Hits              ?     3097           
  Misses            ?     1328           
  Partials          ?        0
Impacted Files Coverage Δ
src/wiki/core/plugins/registry.py 95.45% <100%> (ø)
src/wiki/core/markdown/__init__.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc8357c...75e11c3. Read the comment docs.

@benjaoming benjaoming merged commit c4eb76c into django-wiki:master Oct 9, 2017

1 of 3 checks passed

codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

benjaoming added a commit that referenced this pull request Oct 9, 2017

@jenda1 jenda1 deleted the jenda1:plugin-html-tags branch Oct 11, 2017

@jenda1 jenda1 restored the jenda1:plugin-html-tags branch Feb 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment