New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 storage fix #907

Merged
merged 3 commits into from Aug 29, 2018

Conversation

Projects
None yet
2 participants
@superandrew
Contributor

superandrew commented Aug 29, 2018

This should fix #870

superandrew added some commits Jun 10, 2018

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Aug 29, 2018

Codecov Report

Merging #907 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #907      +/-   ##
==========================================
- Coverage   74.31%   74.24%   -0.07%     
==========================================
  Files         106      106              
  Lines        4326     4330       +4     
==========================================
  Hits         3215     3215              
- Misses       1111     1115       +4
Impacted Files Coverage Δ
src/wiki/plugins/images/models.py 53.93% <0%> (-2.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60c0589...e18ef7e. Read the comment docs.

codecov bot commented Aug 29, 2018

Codecov Report

Merging #907 into master will decrease coverage by 0.06%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #907      +/-   ##
==========================================
- Coverage   74.31%   74.24%   -0.07%     
==========================================
  Files         106      106              
  Lines        4326     4330       +4     
==========================================
  Hits         3215     3215              
- Misses       1111     1115       +4
Impacted Files Coverage Δ
src/wiki/plugins/images/models.py 53.93% <0%> (-2.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60c0589...e18ef7e. Read the comment docs.

@benjaoming

LGTM! Thanks for fixing this 👍

@benjaoming benjaoming merged commit e2fc45f into django-wiki:master Aug 29, 2018

1 of 3 checks passed

codecov/patch 0% of diff hit (target 74.31%)
Details
codecov/project 74.24% (-0.07%) compared to 60c0589
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment