Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed assertTrue/assertFalse to better test methods. #972

Merged
merged 1 commit into from Sep 26, 2019

Conversation

@atombrella
Copy link
Contributor

commented Sep 26, 2019

assertTrue and assertFalse should not be used to test for not None or None
values.

assertTrue and assertFalse should not be used to test for not None or None
values.
@codecov

This comment has been minimized.

Copy link

commented Sep 26, 2019

Codecov Report

Merging #972 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #972   +/-   ##
=======================================
  Coverage   75.36%   75.36%           
=======================================
  Files         107      107           
  Lines        4355     4355           
=======================================
  Hits         3282     3282           
  Misses       1073     1073

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f790df4...10c6691. Read the comment docs.

Copy link
Member

left a comment

That makes total sense, thanks for updating the codebase for Django 2+!! 🎉

@benjaoming benjaoming merged commit cccf6d5 into django-wiki:master Sep 26, 2019
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing f790df4...10c6691
Details
codecov/project 75.36% remains the same compared to f790df4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@atombrella atombrella deleted the atombrella:assert_methods branch Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.