-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SOCK_NONBLOCK
from socket creation on tests
#321
Conversation
This fixes running tests on Mac OS X, which lacks the `SOCK_NONBLOCK` socket flag creation.
I wish I could remember why it was there in the first place, but I can't think of a good reason and the tests seem to pass, so... sure? You'll need to pin the version of Click to fix that linting error for now though - see psf/black#2964 |
@andrewgodwin I'm sorry I don't know what's the most appropriate way to pin click, not familiar with python/django development, and I don't see a conclusive way to do so out of the box. A pointer will do, thanks! |
Here: Lines 37 to 41 in cde961b
Add |
Due to an incompatibility with black linter, pin click to 8.0.4: psf/black#2964
Thank you @Kludex. Done. |
Looks like I got it wrong there - it was the pre-commit hook that needed fixing! I've made the changes for you - thanks for the PR! |
That was my first try, but I did undo it just because I didn't know if it was what you wanted :) Thanks for the reviews! |
This fixes running tests on Mac OS X, which lacks the
SOCK_NONBLOCK
socket flag creation.