Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix root_path type in WebSocket Connection Scope #329

Merged
merged 1 commit into from
May 12, 2022

Conversation

abersheeran
Copy link
Contributor

@abersheeran abersheeran commented May 12, 2022

This should be a Unicode String as in HTTP instead of a byte String.

@Kludex
Copy link
Contributor

Kludex commented May 12, 2022

Probably doesn't matter, as it's clearly a typo. But... Both Hypercorn and Uvicorn considered root_path as Unicode string already.

Good catch @abersheeran 👍

@andrewgodwin
Copy link
Member

Yes, it appears literally everything treats it as a unicode string already (including WsgiToAsgi), so I'm OK correcting this without a major revision.

@andrewgodwin andrewgodwin merged commit 7794c2a into django:main May 12, 2022
@abersheeran abersheeran deleted the patch-1 branch May 13, 2022 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants