Skip to content
Browse files

[1.0.X] Fixed insert/update handling when no database interaction is …


Fixed #10205 as part of this.

Backport of r9926 from trunk.

git-svn-id: bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
1 parent 283c89e commit 016f12a2c27fd6006d43cc32af734dfd0ea96f98 @malcolmt malcolmt committed
8 django/db/models/sql/
@@ -1743,9 +1743,11 @@ def execute_sql(self, result_type=MULTI):
iterator over the results if the result_type is MULTI.
result_type is either MULTI (use fetchmany() to retrieve all rows),
- SINGLE (only retrieve a single row), or None (no results expected, but
- the cursor is returned, since it's used by subclasses such as
- InsertQuery).
+ SINGLE (only retrieve a single row), or None. In this last case, the
+ cursor is returned if any query is executed, since it's used by
+ subclasses such as InsertQuery). It's possible, however, that no query
+ is needed, as the filters describe an empty set. In that case, None is
+ returned, to avoid any unnecessary database interaction.
sql, params = self.as_sql()
4 django/db/models/sql/
@@ -115,7 +115,7 @@ def execute_sql(self, result_type=None):
tables, but their rowcounts are not returned).
cursor = super(UpdateQuery, self).execute_sql(result_type)
- rows = cursor.rowcount
+ rows = cursor and cursor.rowcount or 0
del cursor
for query in self.get_related_updates():
@@ -307,7 +307,7 @@ def as_sql(self):
def execute_sql(self, return_id=False):
cursor = super(InsertQuery, self).execute_sql(None)
- if return_id:
+ if return_id and cursor:
return self.connection.ops.last_insert_id(cursor,
14 tests/regressiontests/queries/
@@ -1056,6 +1056,20 @@ def __unicode__(self):
Bug #9985 -- qs.values_list(...).values(...) combinations should work.
>>> Note.objects.values_list("note", flat=True).values("id").order_by("id")
[{'id': 1}, {'id': 2}, {'id': 3}]
+>>> Annotation.objects.filter(notes__in=Note.objects.filter(note="n1").values_list('note').values('id'))
+[<Annotation: a1>]
+Bug #10028 -- ordering by model related to nullable relations(!) should use
+outer joins, so that all results are included.
+>>> _ = Plaything.objects.create(name="p1")
+>>> Plaything.objects.all()
+[<Plaything: p1>]
+Bug #10205 -- When bailing out early because of an empty "__in" filter, we need
+to set things up correctly internally so that subqueries can continue properly.
+>>> Tag.objects.filter(name__in=()).update(name="foo")
# In Python 2.3 and the Python 2.6 beta releases, exceptions raised in __len__

0 comments on commit 016f12a

Please sign in to comment.
Something went wrong with that request. Please try again.