Browse files

[1.7.x] Fixed #22786 -- Documented value_from_datadict caveat

Thanks blueyed for the report and Tim Graham for the review.
Backport of 909015a from master.
  • Loading branch information...
1 parent f201cfa commit 022fdb2ac4a795af0fb1808942b260e2dc3d404d @claudep claudep committed Aug 29, 2014
Showing with 6 additions and 1 deletion.
  1. +6 −1 docs/ref/forms/widgets.txt
7 docs/ref/forms/widgets.txt
@@ -217,7 +217,12 @@ foundation for custom widgets.
.. method:: value_from_datadict(data, files, name)
Given a dictionary of data and this widget's name, returns the value
- of this widget. Returns ``None`` if a value wasn't provided.
+ of this widget. ``files`` may contain data coming from
+ :attr:`request.FILES <django.http.HttpRequest.FILES>`. Returns ``None``
+ if a value wasn't provided. Note also that ``value_from_datadict`` may
+ be called more than once during handling of form data, so if you
+ customize it and add expensive processing, you should implement some
+ caching mechanism yourself.
.. class:: MultiWidget(widgets, attrs=None)

0 comments on commit 022fdb2

Please sign in to comment.