Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixed #6305 -- Always emit the got_request_exception signal, even when

DEBUG=True. Patch from Collin Anderson.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@7068 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 050b8a436a3016b0211333be3b5ecf7a098fc4bf 1 parent 3815ff7
@malcolmt malcolmt authored
Showing with 5 additions and 4 deletions.
  1. +1 −0  AUTHORS
  2. +4 −4 django/core/handlers/base.py
View
1  AUTHORS
@@ -45,6 +45,7 @@ answer newbie questions, and generally made Django that much better:
Marty Alchin <gulopine@gamemusic.org>
Daniel Alves Barbosa de Oliveira Vaz <danielvaz@gmail.com>
AgarFu <heaven@croasanaso.sytes.net>
+ Collin Anderson <cmawebsite@gmail.com>
Andreas
andy@jadedplanet.net
Fabrice Aneche <akh@nobugware.com>
View
8 django/core/handlers/base.py
@@ -111,13 +111,13 @@ def get_response(self, request):
except SystemExit:
pass # See http://code.djangoproject.com/ticket/1023
except: # Handle everything else, including SuspiciousOperation, etc.
+ # Get the exception info now, in case another exception is thrown later.
+ exc_info = sys.exc_info()
+ receivers = dispatcher.send(signal=signals.got_request_exception, request=request)
if settings.DEBUG:
from django.views import debug
- return debug.technical_500_response(request, *sys.exc_info())
+ return debug.technical_500_response(request, *exc_info)
else:
- # Get the exception info now, in case another exception is thrown later.
- exc_info = sys.exc_info()
- receivers = dispatcher.send(signal=signals.got_request_exception, request=request)
# When DEBUG is False, send an error message to the admins.
subject = 'Error (%s IP): %s' % ((request.META.get('REMOTE_ADDR') in settings.INTERNAL_IPS and 'internal' or 'EXTERNAL'), request.path)
try:
Please sign in to comment.
Something went wrong with that request. Please try again.