Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Fixed #5749 -- Added field_name as a key in the _html_output dict

Thanks SmileyChris for the suggestion.
  • Loading branch information...
commit 053de6131af83c63ec17d38578889c71de913d24 1 parent 4840fd9
@e0ne e0ne authored timgraham committed
Showing with 13 additions and 1 deletion.
  1. +2 −1  django/forms/forms.py
  2. +11 −0 tests/forms_tests/tests/test_forms.py
View
3  django/forms/forms.py
@@ -185,7 +185,8 @@ def _html_output(self, normal_row, error_row, row_ender, help_text_html, errors_
'label': force_text(label),
'field': six.text_type(bf),
'help_text': help_text,
- 'html_class_attr': html_class_attr
+ 'html_class_attr': html_class_attr,
+ 'field_name': bf.html_name,
})
if top_errors:
View
11 tests/forms_tests/tests/test_forms.py
@@ -1950,3 +1950,14 @@ class SomeForm(Form):
boundfield = SomeForm(label_suffix='!')['field']
self.assertHTMLEqual(boundfield.label_tag(label_suffix='$'), '<label for="id_field">Field$</label>')
+
+ def test_field_name(self):
+ """#5749 - `field_name` may be used as a key in _html_output()."""
+ class SomeForm(Form):
+ some_field = CharField()
+
+ def as_p(self):
+ return self._html_output(u'<p id="p_%(field_name)s"></p>', u'%s', '</p>', u' %s', True)
+
+ form = SomeForm()
+ self.assertHTMLEqual(form.as_p(), '<p id="p_some_field"></p>')
Please sign in to comment.
Something went wrong with that request. Please try again.