Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Fixed #778 -- Improved isExistingURL validator not to raise Validatio…

…nError for URLs that exist but require authorization. Thanks for the report, lakin wrecker.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@1202 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 0a74c68eeebb827736f2370dc67d0d72619025f2 1 parent 1bf6dd7
@adrianholovaty adrianholovaty authored
Showing with 5 additions and 1 deletion.
  1. +5 −1 django/core/validators.py
View
6 django/core/validators.py
@@ -199,7 +199,11 @@ def isExistingURL(field_data, all_data):
u = urllib2.urlopen(field_data)
except ValueError:
raise ValidationError, _("Invalid URL: %s") % field_data
- except: # urllib2.HTTPError, urllib2.URLError, httplib.InvalidURL, etc.
+ except urllib2.HTTPError, e:
+ # 401s are valid; they just mean authorization is required.
+ if e.code not in ('401',):
+ raise ValidationError, _("The URL %s is a broken link.") % field_data
+ except: # urllib2.URLError, httplib.InvalidURL, etc.
raise ValidationError, _("The URL %s is a broken link.") % field_data
def isValidUSState(field_data, all_data):
Please sign in to comment.
Something went wrong with that request. Please try again.