Permalink
Browse files

[1.2.X] Fixed some bugs with formtools tests.

Without these checks, it is possible for the tests to pass by virtue of
asserts never being reached for some reason (very possible in this case, due
to handling of security hashes).

Backport of [15198] from trunk.

git-svn-id: http://code.djangoproject.com/svn/django/branches/releases/1.2.X@15200 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
1 parent 444bda0 commit 0ebb02e9dc2ea9906e2db36dc3f7d998231d462f @spookylukey spookylukey committed Jan 13, 2011
Showing with 3 additions and 0 deletions.
  1. +3 −0 django/contrib/formtools/tests.py
View
3 django/contrib/formtools/tests.py
@@ -247,6 +247,7 @@ def test_15075(self):
Regression test for ticket #15075. Allow modifying wizard's form_list
in process_step.
"""
+ reached = [False]
that = self
class WizardWithProcessStep(WizardClass):
@@ -255,6 +256,7 @@ def process_step(self, request, form, step):
self.form_list[1] = WizardPageTwoAlternativeForm
if step == 1:
that.assertTrue(isinstance(form, WizardPageTwoAlternativeForm))
+ reached[0] = True
wizard = WizardWithProcessStep([WizardPageOneForm,
WizardPageTwoForm,
@@ -264,3 +266,4 @@ def process_step(self, request, form, step):
"hash_0": "2fdbefd4c0cad51509478fbacddf8b13",
"wizard_step": "1"}
wizard(DummyRequest(POST=data))
+ self.assertTrue(reached[0])

0 comments on commit 0ebb02e

Please sign in to comment.