Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixed #11859. Allowed subclasses of tuple or list for choice options.…

… Thanks, Alex Gaynor.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@12535 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 0f1769555e1d43ff83f3a715095ac28f24499c2a 1 parent f2d5582
@jkocherhans jkocherhans authored
Showing with 1 addition and 1 deletion.
  1. +1 −1  django/core/management/validation.py
View
2  django/core/management/validation.py
@@ -62,7 +62,7 @@ def get_validation_errors(outfile, app=None):
e.add(opts, '"%s": "choices" should be iterable (e.g., a tuple or list).' % f.name)
else:
for c in f.choices:
- if not type(c) in (tuple, list) or len(c) != 2:
+ if not isinstance(c, (list, tuple)) or len(c) != 2:
e.add(opts, '"%s": "choices" should be a sequence of two-tuples.' % f.name)
if f.db_index not in (None, True, False):
e.add(opts, '"%s": "db_index" should be either None, True or False.' % f.name)
Please sign in to comment.
Something went wrong with that request. Please try again.