Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Fixed #3821 -- Added a widget class attribute to ChoiceField and

MultipleChoiceField. This makes them consistent with other field classes and
make subclassing easier. This is a backwards compatible change. Thanks, Max
Dekachev.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@5053 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 15d5c3decb79c8a1af7131b8e53d12181c790e2f 1 parent 2a512a4
@malcolmt malcolmt authored
Showing with 5 additions and 4 deletions.
  1. +1 −0  AUTHORS
  2. +4 −4 django/newforms/fields.py
View
1  AUTHORS
@@ -78,6 +78,7 @@ answer newbie questions, and generally made Django that much better:
Jason Davies (Esaj) <http://www.jasondavies.com/>
Alex Dedul
deric@monowerks.com
+ Max Derkachev <mderk@yandex.ru>
dne@mayonnaise.net
Maximillian Dornseif <md@hudora.de>
Jeremy Dunck <http://dunck.us/>
View
8 django/newforms/fields.py
@@ -332,7 +332,9 @@ def clean(self, value):
return {True: True, False: False}.get(value, None)
class ChoiceField(Field):
- def __init__(self, choices=(), required=True, widget=Select, label=None, initial=None, help_text=None):
+ widget = Select
+
+ def __init__(self, choices=(), required=True, widget=None, label=None, initial=None, help_text=None):
super(ChoiceField, self).__init__(required, widget, label, initial, help_text)
self.choices = choices
@@ -364,9 +366,7 @@ def clean(self, value):
class MultipleChoiceField(ChoiceField):
hidden_widget = MultipleHiddenInput
-
- def __init__(self, choices=(), required=True, widget=SelectMultiple, label=None, initial=None, help_text=None):
- super(MultipleChoiceField, self).__init__(choices, required, widget, label, initial, help_text)
+ widget = SelectMultiple
def clean(self, value):
"""
Please sign in to comment.
Something went wrong with that request. Please try again.