Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Browse files

Fixed #4390, #4385 -- Made it clear that cleaned_data wasn't being as…

…signed to

twice without reason. Also make sure that if field specific clean functions
fail, the form-wide field cleaning is removed from cleaned_data.

git-svn-id: bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
1 parent dfdf7bd commit 198127a0f272e1af60c2e00befe80c96cf498a7f @malcolmt malcolmt committed
Showing with 3 additions and 1 deletion.
  1. +3 −1 django/newforms/
4 django/newforms/
@@ -188,9 +188,11 @@ def full_clean(self):
self.cleaned_data[name] = value
if hasattr(self, 'clean_%s' % name):
value = getattr(self, 'clean_%s' % name)()
- self.cleaned_data[name] = value
+ self.cleaned_data[name] = value
except ValidationError, e:
errors[name] = e.messages
+ if name in self.cleaned_data:
+ del self.cleaned_data[name]
self.cleaned_data = self.clean()
except ValidationError, e:

0 comments on commit 198127a

Please sign in to comment.
Something went wrong with that request. Please try again.