Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Fixed #4390, #4385 -- Made it clear that cleaned_data wasn't being as…

…signed to

twice without reason. Also make sure that if field specific clean functions
fail, the form-wide field cleaning is removed from cleaned_data.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@5346 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 198127a0f272e1af60c2e00befe80c96cf498a7f 1 parent dfdf7bd
Malcolm Tredinnick authored May 26, 2007

Showing 1 changed file with 3 additions and 1 deletion. Show diff stats Hide diff stats

  1. 4  django/newforms/forms.py
4  django/newforms/forms.py
@@ -188,9 +188,11 @@ def full_clean(self):
188 188
                 self.cleaned_data[name] = value
189 189
                 if hasattr(self, 'clean_%s' % name):
190 190
                     value = getattr(self, 'clean_%s' % name)()
191  
-                self.cleaned_data[name] = value
  191
+                    self.cleaned_data[name] = value
192 192
             except ValidationError, e:
193 193
                 errors[name] = e.messages
  194
+                if name in self.cleaned_data:
  195
+                    del self.cleaned_data[name]
194 196
         try:
195 197
             self.cleaned_data = self.clean()
196 198
         except ValidationError, e:

0 notes on commit 198127a

Please sign in to comment.
Something went wrong with that request. Please try again.