Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixed #15593 -- Added a note that the output of `reverse` is urlquote…

…d. Thanks to guettli for the report and draft patch.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@16054 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 1b1060c9168227e9ff4b1e9141ba6086134030bd 1 parent 6bdaef2
Gabriel Hurley authored
Showing with 16 additions and 2 deletions.
  1. +2 −0  docs/ref/unicode.txt
  2. +14 −2 docs/topics/http/urls.txt
2  docs/ref/unicode.txt
View
@@ -140,6 +140,8 @@ Normally, you'll only need to use ``smart_unicode()``. Call it as early as
possible on any input data that might be either Unicode or a bytestring, and
from then on, you can treat the result as always being Unicode.
+.. _uri-and-iri-handling:
+
URI and IRI handling
~~~~~~~~~~~~~~~~~~~~
16 docs/topics/http/urls.txt
View
@@ -772,9 +772,9 @@ reverse()
If you need to use something similar to the :ttag:`url` template tag in
your code, Django provides the following method (in the
-``django.core.urlresolvers`` module):
+:mod:`django.core.urlresolvers` module):
-.. function:: reverse(viewname, urlconf=None, args=None, kwargs=None, current_app=None)
+.. function:: reverse(viewname, [urlconf=None, args=None, kwargs=None, current_app=None])
``viewname`` is either the function name (either a function reference, or the
string version of the name, if you used that form in ``urlpatterns``) or the
@@ -815,6 +815,18 @@ namespaces into URLs on specific application instances, according to the
be imported correctly. Do not include lines that reference views you
haven't written yet, because those views will not be importable.
+.. note::
+
+ The string returned by :meth:`~django.core.urlresolvers.reverse` is already
+ :ref:`urlquoted <uri-and-iri-handling>`. For example::
+
+ >>> reverse('cities', args=u'Orléans')
+ '.../Orl%C3%A9ans/'
+
+ Applying further encoding (such as :meth:`~django.utils.http.urlquote` or
+ ``urllib.quote``) to the ouput of :meth:`~django.core.urlresolvers.reverse`
+ may produce undesirable results.
+
resolve()
---------
Please sign in to comment.
Something went wrong with that request. Please try again.