Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Fixed #19918 -- Modified select_for_update to run on the write database.

  • Loading branch information...
commit 1c64a0f29e47a3da1dfac06b04ef84280bd809a7 1 parent 1280675
@kux kux authored timgraham committed
Showing with 14 additions and 1 deletion.
  1. +1 −0  django/db/models/query.py
  2. +13 −1 tests/select_for_update/tests.py
View
1  django/db/models/query.py
@@ -742,6 +742,7 @@ def select_for_update(self, **kwargs):
# Default to false for nowait
nowait = kwargs.pop('nowait', False)
obj = self._clone()
+ obj._for_write = True
obj.query.select_for_update = True
obj.query.select_for_update_nowait = nowait
return obj
View
14 tests/select_for_update/tests.py
@@ -5,11 +5,13 @@
import unittest
from django.conf import settings
-from django.db import transaction, connection
+from django.db import transaction, connection, router
from django.db.utils import ConnectionHandler, DEFAULT_DB_ALIAS, DatabaseError
from django.test import (TransactionTestCase, skipIfDBFeature,
skipUnlessDBFeature)
+from multiple_database.tests import TestRouter
+
from .models import Person
# Some tests require threading, which might not be available. So create a
@@ -254,3 +256,13 @@ def test_transaction_dirty_managed(self):
"""
people = list(Person.objects.select_for_update())
self.assertTrue(transaction.is_dirty())
+
+ @skipUnlessDBFeature('has_select_for_update')
+ def test_select_for_update_on_multidb(self):
+ old_routers = router.routers
+ try:
+ router.routers = [TestRouter()]
+ query = Person.objects.select_for_update()
+ self.assertEqual(router.db_for_write(Person), query.db)
+ finally:
+ router.routers = old_routers
Please sign in to comment.
Something went wrong with that request. Please try again.