Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Browse files

Fixed #15378 -- Now properly handle OGR layers that have features wit…

…h invalid geometries. Thanks, kunitoki for bug report and initial patch.

git-svn-id: bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
1 parent dd3313b commit 1fdbcadd223641f63d0548c39860d255cef325ed @jbronn jbronn committed
BIN  django/contrib/gis/tests/data/invalid/emptypoints.dbf
Binary file not shown
BIN  django/contrib/gis/tests/data/invalid/emptypoints.shp
Binary file not shown
BIN  django/contrib/gis/tests/data/invalid/emptypoints.shx
Binary file not shown
3  django/contrib/gis/tests/layermap/
@@ -43,6 +43,9 @@ class ICity1(CityBase):
class ICity2(ICity1):
dt_time = models.DateTimeField(auto_now=True)
+class Invalid(models.Model):
+ point = models.PointField()
# Mapping dictionaries for the models above.
co_mapping = {'name' : 'Name',
'state' : {'name' : 'State'}, # ForeignKey's use another mapping dictionary for the _related_ Model (State in this case).
14 django/contrib/gis/tests/layermap/
@@ -4,16 +4,19 @@
from django.utils.copycompat import copy
from django.utils.unittest import TestCase
-from django.contrib.gis.gdal import DataSource
+from django.contrib.gis.gdal import DataSource, OGRException
from django.contrib.gis.tests.utils import mysql
from django.contrib.gis.utils.layermapping import LayerMapping, LayerMapError, InvalidDecimal, MissingForeignKey
-from models import City, County, CountyFeat, Interstate, ICity1, ICity2, State, city_mapping, co_mapping, cofeat_mapping, inter_mapping
+from models import \
+ City, County, CountyFeat, Interstate, ICity1, ICity2, Invalid, State, \
+ city_mapping, co_mapping, cofeat_mapping, inter_mapping
shp_path = os.path.realpath(os.path.join(os.path.dirname(__file__), os.pardir, 'data'))
city_shp = os.path.join(shp_path, 'cities', 'cities.shp')
co_shp = os.path.join(shp_path, 'counties', 'counties.shp')
inter_shp = os.path.join(shp_path, 'interstates', 'interstates.shp')
+invalid_shp = os.path.join(shp_path, 'invalid', 'emptypoints.shp')
# Dictionaries to hold what's expected in the county shapefile.
NAMES = ['Bexar', 'Galveston', 'Harris', 'Honolulu', 'Pueblo']
@@ -265,3 +268,10 @@ def test06_model_inheritance(self):
self.assertEqual(6, ICity1.objects.count())
self.assertEqual(3, ICity2.objects.count())
+ def test07_invalid_layer(self):
+ "Tests LayerMapping on invalid geometries. See #15378."
+ invalid_mapping = {'point': 'POINT'}
+ lm = LayerMapping(Invalid, invalid_shp, invalid_mapping,
+ source_srs=4326)
5 django/contrib/gis/utils/
@@ -294,7 +294,10 @@ def feature_kwargs(self, feat):
if isinstance(model_field, GeometryField):
# Verify OGR geometry.
- val = self.verify_geom(feat.geom, model_field)
+ try:
+ val = self.verify_geom(feat.geom, model_field)
+ except OGRException:
+ raise LayerMapError('Could not retrieve geometry from feature.')
elif isinstance(model_field, models.base.ModelBase):
# The related _model_, not a field was passed in -- indicating
# another mapping for the related Model.

0 comments on commit 1fdbcad

Please sign in to comment.
Something went wrong with that request. Please try again.