Skip to content

Commit

Permalink
Fixed #4887 -- Fixed another place where template tag arguments are used
Browse files Browse the repository at this point in the history
directly as function keyword args. Thanks, Brian Rosner.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@5715 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information
malcolmt committed Jul 16, 2007
1 parent 58096c4 commit 29891ad
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions AUTHORS
Expand Up @@ -222,6 +222,7 @@ answer newbie questions, and generally made Django that much better:
rhettg@gmail.com
Henrique Romano <onaiort@gmail.com>
Armin Ronacher
Brian Rosner <brosner@gmail.com>
Oliver Rutherfurd <http://rutherfurd.net/>
Ivan Sagalaev (Maniac) <http://www.softwaremaniacs.org/>
Vinay Sajip <vinay_sajip@yahoo.co.uk>
Expand Down
2 changes: 2 additions & 0 deletions django/contrib/comments/templatetags/comments.py
Expand Up @@ -5,6 +5,7 @@
from django.template import loader
from django.core.exceptions import ObjectDoesNotExist
from django.contrib.contenttypes.models import ContentType
from django.utils.encoding import smart_str
import re

register = template.Library()
Expand Down Expand Up @@ -174,6 +175,7 @@ def __call__(self, parser, token):
if tokens[4] != 'with':
raise template.TemplateSyntaxError, "Fourth argument in %r tag must be 'with'" % tokens[0]
for option, args in zip(tokens[5::2], tokens[6::2]):
option = smart_str(option)
if option in ('photos_optional', 'photos_required') and not self.free:
# VALIDATION ##############################################
option_list = args.split(',')
Expand Down

0 comments on commit 29891ad

Please sign in to comment.