Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Fixed 19895 -- Made second iteration over invalid queryset raise an e…

…xception too

When iteration over a queryset raised an exception, the result cache
remained initialized with an empty list, so subsequent iterations returned
an empty list instead of raising an exception
  • Loading branch information...
commit 2cd0edaa477b327024e4007c8eaf46646dcd0f21 1 parent 4c05fdb
@gnosek gnosek authored jacobian committed
Showing with 19 additions and 2 deletions.
  1. +13 −1 django/db/models/query.py
  2. +6 −1 tests/modeltests/basic/tests.py
View
14 django/db/models/query.py
@@ -104,7 +104,7 @@ def __iter__(self):
len(self)
if self._result_cache is None:
- self._iter = self.iterator()
+ self._iter = self._safe_iterator(self.iterator())
self._result_cache = []
if self._iter:
return self._result_iter()
@@ -341,6 +341,18 @@ def iterator(self):
yield obj
+ def _safe_iterator(self, iterator):
+ # ensure result cache is cleared when iterating over a queryset
+ # raises an exception
+ try:
+ for item in iterator:
+ yield item
+ except StopIteration:
+ raise
+ except Exception:
+ self._result_cache = None
+ raise
+
def aggregate(self, *args, **kwargs):
"""
Returns a dictionary containing the calculations (aggregation)
View
7 tests/modeltests/basic/tests.py
@@ -2,7 +2,7 @@
from datetime import datetime
-from django.core.exceptions import ObjectDoesNotExist, MultipleObjectsReturned
+from django.core.exceptions import ObjectDoesNotExist, MultipleObjectsReturned, FieldError
from django.db.models.fields import Field, FieldDoesNotExist
from django.db.models.query import QuerySet, EmptyQuerySet, ValuesListQuerySet
from django.test import TestCase, skipIfDBFeature, skipUnlessDBFeature
@@ -686,3 +686,8 @@ def test_emptyqs_distinct(self):
Article.objects.create(headline='foo', pub_date=datetime.now())
with self.assertNumQueries(0):
self.assertEqual(len(Article.objects.none().distinct('headline', 'pub_date')), 0)
+
+ def test_invalid_qs_list(self):
+ qs = Article.objects.order_by('invalid_column')
+ self.assertRaises(FieldError, list, qs)
+ self.assertRaises(FieldError, list, qs)
Please sign in to comment.
Something went wrong with that request. Please try again.