Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixed a regression caused by fix for #21428

On Python 3 sorting Fields mixed with GenericForeignKeys doesn't work
as GenericForeignKey isn't a subclass of django.db.models.fields.Field.

Refs #21428.
  • Loading branch information...
commit 326539f6a4936cda031b4a5f7caad788569f3329 1 parent 0e079e4
Anssi Kääriäinen akaariai authored
Showing with 5 additions and 1 deletion.
  1. +5 −1 django/forms/
6 django/forms/
@@ -179,7 +179,11 @@ def fields_for_model(model, fields=None, exclude=None, widgets=None,
field_list = []
ignored = []
opts = model._meta
- for f in sorted(opts.concrete_fields + opts.virtual_fields + opts.many_to_many):
+ # Avoid circular import
+ from django.db.models.fields import Field as ModelField
+ sortable_virtual_fields = [f for f in opts.virtual_fields
+ if isinstance(f, ModelField)]
+ for f in sorted(opts.concrete_fields + sortable_virtual_fields + opts.many_to_many):
if not getattr(f, 'editable', False):
if fields is not None and not in fields:
Please sign in to comment.
Something went wrong with that request. Please try again.