Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Ensure that a Popen object is closed promptly during the tests.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@14853 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 3863c906ce65c56e700ae3631639b746a0a596d3 1 parent 68a04f2
Alex Gaynor authored December 08, 2010
1  tests/regressiontests/admin_scripts/tests.py
@@ -119,6 +119,7 @@ def run_test(self, script, args, settings_file=None, apps=None):
119 119
             from subprocess import Popen, PIPE
120 120
             p = Popen(cmd, shell=True, stdin=PIPE, stdout=PIPE, stderr=PIPE)
121 121
             stdin, stdout, stderr = (p.stdin, p.stdout, p.stderr)
  122
+            p.wait()
122 123
         except ImportError:
123 124
             stdin, stdout, stderr = os.popen3(cmd)
124 125
         out, err = stdout.read(), stderr.read()

0 notes on commit 3863c90

Please sign in to comment.
Something went wrong with that request. Please try again.