Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixed #9706: made SlugField honor max_length in Oracle, matching the …

…other backends.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@9548 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 4637a77ff8fedd67b3aaa98042d89e03465a82d6 1 parent 4853160
Ian Kelly ikelly authored
2  django/db/backends/oracle/creation.py
View
@@ -32,7 +32,7 @@ class DatabaseCreation(BaseDatabaseCreation):
'OneToOneField': 'NUMBER(11)',
'PositiveIntegerField': 'NUMBER(11) CHECK (%(qn_column)s >= 0)',
'PositiveSmallIntegerField': 'NUMBER(11) CHECK (%(qn_column)s >= 0)',
- 'SlugField': 'NVARCHAR2(50)',
+ 'SlugField': 'NVARCHAR2(%(max_length)s)',
'SmallIntegerField': 'NUMBER(11)',
'TextField': 'NCLOB',
'TimeField': 'TIMESTAMP',
9 tests/regressiontests/model_fields/models.py
View
@@ -36,6 +36,9 @@ class Whiz(models.Model):
class BigD(models.Model):
d = models.DecimalField(max_digits=38, decimal_places=30)
+class BigS(models.Model):
+ s = models.SlugField(max_length=255)
+
__test__ = {'API_TESTS':"""
# Create a couple of Places.
>>> f = Foo.objects.create(a='abc', d=decimal.Decimal("12.34"))
@@ -88,4 +91,10 @@ class BigD(models.Model):
>>> bd = BigD.objects.get(pk=bd.pk)
>>> bd.d == decimal.Decimal("12.9")
True
+
+# Regression test for #9706: ensure SlugField honors max_length.
+>>> bs = BigS.objects.create(s = 'slug' * 50)
+>>> bs = BigS.objects.get(pk=bs.pk)
+>>> bs.s == 'slug' * 50
+True
"""}
Please sign in to comment.
Something went wrong with that request. Please try again.