Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixed #14414 -- Improved contenttypes shortcut() view to check that t…

…he ContentType has a model_class(). Thanks, subsume

git-svn-id: http://code.djangoproject.com/svn/django/trunk@13994 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 47cae1a2f6008382229b985f160846a7083726b6 1 parent 40765f1
Adrian Holovaty adrianholovaty authored
Showing with 2 additions and 0 deletions.
  1. +2 −0  django/contrib/contenttypes/views.py
2  django/contrib/contenttypes/views.py
View
@@ -8,6 +8,8 @@ def shortcut(request, content_type_id, object_id):
# Look up the object, making sure it's got a get_absolute_url() function.
try:
content_type = ContentType.objects.get(pk=content_type_id)
+ if not content_type.model_class():
+ raise http.Http404("Content type %s object has no associated model" % content_type_id)
obj = content_type.get_object_for_this_type(pk=object_id)
except (ObjectDoesNotExist, ValueError):
raise http.Http404("Content type %s object %s doesn't exist" % (content_type_id, object_id))
Please sign in to comment.
Something went wrong with that request. Please try again.