Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

[1.0.X]: Fixed #10094 -- Fixed the `include` and `extends` template t…

…ags to work with filenames with spaces, patch from mcroydon.

Backport of r10211 from trunk.


git-svn-id: http://code.djangoproject.com/svn/django/branches/releases/1.0.X@10212 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 487a7fdccee5b71f1f44acaafbaec58fa05120d5 1 parent daae84a
Gary Wilson Jr. gdub authored
4 django/template/loader_tags.py
View
@@ -158,7 +158,7 @@ def do_extends(parser, token):
name of the parent template to extend (if it evaluates to a string) or as
the parent tempate itelf (if it evaluates to a Template object).
"""
- bits = token.contents.split()
+ bits = token.split_contents()
if len(bits) != 2:
raise TemplateSyntaxError, "'%s' takes one argument" % bits[0]
parent_name, parent_name_expr = None, None
@@ -179,7 +179,7 @@ def do_include(parser, token):
{% include "foo/some_include" %}
"""
- bits = token.contents.split()
+ bits = token.split_contents()
if len(bits) != 2:
raise TemplateSyntaxError, "%r tag takes one argument: the name of the template to be included" % bits[0]
path = bits[1]
8 tests/regressiontests/templates/tests.py
View
@@ -647,6 +647,8 @@ def get_template_tests(self):
'include02': ('{% include "basic-syntax02" %}', {'headline': 'Included'}, "Included"),
'include03': ('{% include template_name %}', {'template_name': 'basic-syntax02', 'headline': 'Included'}, "Included"),
'include04': ('a{% include "nonexistent" %}b', {}, "ab"),
+ 'include 05': ('template with a space', {}, 'template with a space'),
+ 'include06': ('{% include "include 05"%}', {}, 'template with a space'),
### NAMED ENDBLOCKS #######################################################
@@ -746,6 +748,12 @@ def get_template_tests(self):
# Inheritance from a template that doesn't have any blocks
'inheritance27': ("{% extends 'inheritance26' %}", {}, 'no tags'),
+ # Set up a base template with a space in it.
+ 'inheritance 28': ("{% block first %}!{% endblock %}", {}, '!'),
+
+ # Inheritance from a template with a space in its name should work.
+ 'inheritance29': ("{% extends 'inheritance 28' %}", {}, '!'),
+
### I18N ##################################################################
# {% spaceless %} tag
Please sign in to comment.
Something went wrong with that request. Please try again.