Permalink
Browse files

Add a note about discouraging whitespace- or formatting-only patches.

We follow the python-dev path here. Deliberately.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@16691 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
1 parent 3e65f96 commit 499f01842eac1d1248fbf60df94444c08282ef3a @malcolmt malcolmt committed Aug 26, 2011
Showing with 4 additions and 1 deletion.
  1. +4 −1 docs/internals/contributing/writing-code/coding-style.txt
@@ -188,7 +188,10 @@ Miscellaneous
add unnecessary bytes, add visual clutter to the patches and can also
occasionally cause unnecessary merge conflicts. Some IDE's can be
configured to automatically remove them and most VCS tools can be set to
- highlight them in diff outputs.
+ highlight them in diff outputs. Note, however, that patches which only
+ remove whitespace (or only make changes for nominal PEP 8 conformance)
+ are likely to be rejected, since they only introduce noise rather than
+ code improvement. Tidy up when you're next changing code in the area.
* Please don't put your name in the code you contribute. Our policy is to
keep contributors' names in the ``AUTHORS`` file distributed with Django

0 comments on commit 499f018

Please sign in to comment.