Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Fixed #14012 (again) -- Admin app: Don't show the full user edition v…

…iew after adding a user in a FK popup. Thanks dburke for reporting this regression introduced in r14628.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@15637 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 4b13e76debbb64818559b504a2dd043af5fcad33 1 parent 12bd7bc
Ramiro Morales authored February 24, 2011
9  django/contrib/auth/admin.py
@@ -142,9 +142,12 @@ def response_add(self, request, obj, post_url_continue='../%s/'):
142 142
         its superclass implementation but is customized because the User model
143 143
         has a slightly different workflow.
144 144
         """
145  
-        if '_addanother' not in request.POST:
146  
-            # The 'Save' button should act like the 'Save and continue
147  
-            # editing' button
  145
+        # We should allow further modification of the user just added i.e. the
  146
+        # 'Save' button should behave like the 'Save and continue editing'
  147
+        # button except in two scenarios:
  148
+        # * The user has pressed the 'Save and add another' button
  149
+        # * We are adding a user in a popup
  150
+        if '_addanother' not in request.POST and '_popup' not in request.POST:
148 151
             request.POST['_continue'] = 1
149 152
         return super(UserAdmin, self).response_add(request, obj, post_url_continue)
150 153
 
12  tests/regressiontests/admin_views/tests.py
@@ -2637,13 +2637,25 @@ def test_password_mismatch(self):
2637 2637
                           [u"The two password fields didn't match."])
2638 2638
 
2639 2639
     def test_user_fk_popup(self):
  2640
+        """Quick user addition in a FK popup shouldn't invoke view for further user customization"""
2640 2641
         response = self.client.get('/test_admin/admin/admin_views/album/add/')
2641 2642
         self.assertEqual(response.status_code, 200)
2642 2643
         self.assertContains(response, '/test_admin/admin/auth/user/add')
2643 2644
         self.assertContains(response, 'class="add-another" id="add_id_owner" onclick="return showAddAnotherPopup(this);"')
2644 2645
         response = self.client.get('/test_admin/admin/auth/user/add/?_popup=1')
  2646
+        self.assertEqual(response.status_code, 200)
2645 2647
         self.assertNotContains(response, 'name="_continue"')
2646 2648
         self.assertNotContains(response, 'name="_addanother"')
  2649
+        data = {
  2650
+            'username': 'newuser',
  2651
+            'password1': 'newpassword',
  2652
+            'password2': 'newpassword',
  2653
+            '_popup': '1',
  2654
+            '_save': '1',
  2655
+        }
  2656
+        response = self.client.post('/test_admin/admin/auth/user/add/?_popup=1', data, follow=True)
  2657
+        self.assertEqual(response.status_code, 200)
  2658
+        self.assertContains(response, 'dismissAddAnotherPopup')
2647 2659
 
2648 2660
     def test_save_add_another_button(self):
2649 2661
         user_count = User.objects.count()

0 notes on commit 4b13e76

Please sign in to comment.
Something went wrong with that request. Please try again.