Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixed #11916 -- Corrected handling of aggregation when there is a sub…

…query provided in an extra(select=) clause. Thanks to jaklaassen@gmail.com for the report, and to tobias, paluh, Karen Tracey and Ian Kelly for their work on the fix.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@12896 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 4e5c20b78b17df25948809ca1c880551351d4d83 1 parent a75dc34
@freakboy3742 freakboy3742 authored
View
2  django/db/models/sql/compiler.py
@@ -484,7 +484,7 @@ def get_grouping(self):
elif hasattr(col, 'as_sql'):
result.append(col.as_sql(qn))
else:
- result.append(str(col))
+ result.append('(%s)' % str(col))
return result, params
def fill_related_selections(self, opts=None, root_alias=None, cur_depth=1,
View
30 tests/regressiontests/aggregation_regress/tests.py
@@ -1,5 +1,7 @@
+from django.conf import settings
from django.test import TestCase
-from django.db.models import Max
+from django.db import DEFAULT_DB_ALIAS
+from django.db.models import Count, Max
from regressiontests.aggregation_regress.models import *
@@ -13,7 +15,7 @@ def test_aggregates_in_where_clause(self):
Tests that the subselect works and returns results equivalent to a
query with the IDs listed.
-
+
Before the corresponding fix for this bug, this test passed in 1.1 and
failed in 1.2-beta (trunk).
"""
@@ -33,7 +35,7 @@ def test_aggregates_in_where_clause_pre_eval(self):
Same as the above test, but evaluates the queryset for the subquery
before it's used as a subquery.
-
+
Before the corresponding fix for this bug, this test failed in both
1.1 and 1.2-beta (trunk).
"""
@@ -46,3 +48,25 @@ def test_aggregates_in_where_clause_pre_eval(self):
qs1 = books.filter(id__in=qs)
qs2 = books.filter(id__in=list(qs))
self.assertEqual(list(qs1), list(qs2))
+
+ if settings.DATABASES[DEFAULT_DB_ALIAS]['ENGINE'] != 'django.db.backends.oracle':
+ def test_annotate_with_extra(self):
+ """
+ Regression test for #11916: Extra params + aggregation creates
+ incorrect SQL.
+ """
+ #oracle doesn't support subqueries in group by clause
+ shortest_book_sql = """
+ SELECT name
+ FROM aggregation_regress_book b
+ WHERE b.publisher_id = aggregation_regress_publisher.id
+ ORDER BY b.pages
+ LIMIT 1
+ """
+ # tests that this query does not raise a DatabaseError due to the full
+ # subselect being (erroneously) added to the GROUP BY parameters
+ qs = Publisher.objects.extra(select={
+ 'name_of_shortest_book': shortest_book_sql,
+ }).annotate(total_books=Count('book'))
+ # force execution of the query
+ list(qs)
Please sign in to comment.
Something went wrong with that request. Please try again.