Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Fixed #2662 -- Changed dictfetchmany and dictfetchall to return itera…

…tors,

rather than a list, in order to save memory. Patch from Simon Willison.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@3783 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 4f63ce5b4a625c15718c676f5efb78e0ffa282f5 1 parent 4b5f0e2
@malcolmt malcolmt authored
Showing with 4 additions and 2 deletions.
  1. +4 −2 django/db/backends/util.py
View
6 django/db/backends/util.py
@@ -110,9 +110,11 @@ def dictfetchone(cursor):
def dictfetchmany(cursor, number):
"Returns a certain number of rows from a cursor as a dict"
desc = cursor.description
- return [_dict_helper(desc, row) for row in cursor.fetchmany(number)]
+ for row in cursor.fetchmany(number):
+ yield _dict_helper(desc, row)
def dictfetchall(cursor):
"Returns all rows from a cursor as a dict"
desc = cursor.description
- return [_dict_helper(desc, row) for row in cursor.fetchall()]
+ for row in cursor.fetchall():
+ yield _dict_helper(desc, row)

0 comments on commit 4f63ce5

Please sign in to comment.
Something went wrong with that request. Please try again.