Permalink
Browse files

Fixed a typo from the refactoring in [8455]. With bonus test, too. Th…

…anks, vung.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@8724 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
1 parent 38362a1 commit 51836756d01ab8fb4d98d913c01b61d91962a806 @malcolmt malcolmt committed Aug 29, 2008
Showing with 7 additions and 1 deletion.
  1. +1 −1 django/db/models/query.py
  2. +6 −0 tests/regressiontests/queries/models.py
View
2 django/db/models/query.py
@@ -737,7 +737,7 @@ def _setup_query(self):
self.query.select = []
field = self.model._meta.get_field(self._field_name, many_to_many=False)
assert isinstance(field, DateField), "%r isn't a DateField." \
- % field_name
+ % field.name
self.query.add_date_select(field, self._kind, self._order)
if field.null:
self.query.add_filter(('%s__isnull' % field.name, False))
View
6 tests/regressiontests/queries/models.py
@@ -901,6 +901,12 @@ class Join(models.Model):
>>> qs = Item.objects.dates('created', 'month')
>>> _ = pickle.loads(pickle.dumps(qs))
+Bug #8683 -- raise proper error when a DateQuerySet gets passed a wrong type of field
+>>> Item.objects.dates('name', 'month')
+Traceback (most recent call last):
+...
+AssertionError: 'name' isn't a DateField.
+
Bug #8597: regression tests for case-insensitive comparisons
>>> _ = Item.objects.create(name="a_b", created=datetime.datetime.now(), creator=a2, note=n1)
>>> _ = Item.objects.create(name="x%y", created=datetime.datetime.now(), creator=a2, note=n1)

0 comments on commit 5183675

Please sign in to comment.