Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Added a FIXME that I forgot to include earlier.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@4923 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 56d56e5bac2923382fd10036dbe045412390362d 1 parent 5f2c513
Malcolm Tredinnick authored April 04, 2007

Showing 1 changed file with 4 additions and 0 deletions. Show diff stats Hide diff stats

  1. 4  django/utils/encoding.py
4  django/utils/encoding.py
@@ -6,6 +6,10 @@ def smart_unicode(s):
6 6
         # The input is the result of a gettext_lazy() call, or similar. It will
7 7
         # already be encoded in DEFAULT_CHARSET on evaluation and we don't want
8 8
         # to evaluate it until render time.
  9
+        # FIXME: This isn't totally consistent, because it eventually returns a
  10
+        # bytestring rather than a unicode object. It works wherever we use
  11
+        # smart_unicode() at the moment. Fixing this requires work in the
  12
+        # i18n internals.
9 13
         return s
10 14
     if not isinstance(s, basestring,):
11 15
         if hasattr(s, '__unicode__'):

0 notes on commit 56d56e5

Please sign in to comment.
Something went wrong with that request. Please try again.