Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixed #11162 -- Mentioned ValidationError in custom model field docs

  • Loading branch information...
commit 596e15293c9f522a2b001d49a0c40005711682a6 1 parent 47da7b7
@claudep claudep authored
Showing with 5 additions and 1 deletion.
  1. +5 −1 docs/howto/custom-model-fields.txt
View
6 docs/howto/custom-model-fields.txt
@@ -434,10 +434,14 @@ database, so we need to be able to process strings and ``Hand`` instances in
p1 = re.compile('.{26}')
p2 = re.compile('..')
args = [p2.findall(x) for x in p1.findall(value)]
+ if len(args) != 4:
+ raise ValidationError("Invalid input for a Hand instance")
return Hand(*args)
Notice that we always return a ``Hand`` instance from this method. That's the
-Python object type we want to store in the model's attribute.
+Python object type we want to store in the model's attribute. If anything is
+going wrong during value conversion, you should return a
@charettes Collaborator

I think raise is more appropriate here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
+:exc:`~django.core.exceptions.ValidationError` exception.
**Remember:** If your custom field needs the :meth:`to_python` method to be
called when it is created, you should be using `The SubfieldBase metaclass`_
@charettes

I think raise is more appropriate here.

Please sign in to comment.
Something went wrong with that request. Please try again.