Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Fixed #14795 -- Ensure that get_all_permissions() returns the right r…

…esult (i.e., all permissions) for superusers. Thanks to jay.halleaux@gmail.com for the report, and Brett Haydon for the patch.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@14797 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 5b8ef18dcc006c0fa53b356efbb7cf2c691463d5 1 parent 52c7780
@freakboy3742 freakboy3742 authored
View
8 django/contrib/auth/backends.py
@@ -25,9 +25,11 @@ def get_group_permissions(self, user_obj):
groups.
"""
if not hasattr(user_obj, '_group_perm_cache'):
- perms = Permission.objects.filter(group__user=user_obj
- ).values_list('content_type__app_label', 'codename'
- ).order_by()
+ if user_obj.is_superuser:
+ perms = Permission.objects.all()
+ else:
+ perms = Permission.objects.filter(group__user=user_obj)
+ perms = perms.values_list('content_type__app_label', 'codename').order_by()
user_obj._group_perm_cache = set(["%s.%s" % (ct, name) for ct, name in perms])
return user_obj._group_perm_cache
View
5 django/contrib/auth/tests/auth_backends.py
@@ -15,6 +15,7 @@ def setUp(self):
self.curr_auth = settings.AUTHENTICATION_BACKENDS
settings.AUTHENTICATION_BACKENDS = (self.backend,)
User.objects.create_user('test', 'test@example.com', 'test')
+ User.objects.create_superuser('test2', 'test2@example.com', 'test')
def tearDown(self):
settings.AUTHENTICATION_BACKENDS = self.curr_auth
@@ -90,6 +91,10 @@ def test_has_no_object_perm(self):
self.assertEqual(user.has_perm('auth.test'), True)
self.assertEqual(user.get_all_permissions(), set(['auth.test']))
+ def test_get_all_superuser_permissions(self):
+ "A superuser has all permissions. Refs #14795"
+ user = User.objects.get(username='test2')
+ self.assertEqual(len(user.get_all_permissions()), len(Permission.objects.all()))
class TestObj(object):
pass
Please sign in to comment.
Something went wrong with that request. Please try again.