Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Fixed #21438: makemigrations now detects ManyToManyFields

  • Loading branch information...
commit 5e63977c0e5d0dff755817b86364a5c8882deaf7 1 parent 19b34fb
@andrewgodwin andrewgodwin authored
View
4 django/db/migrations/state.py
@@ -100,6 +100,10 @@ def from_model(cls, model):
name, path, args, kwargs = field.deconstruct()
field_class = import_by_path(path)
fields.append((name, field_class(*args, **kwargs)))
+ for field in model._meta.local_many_to_many:
+ name, path, args, kwargs = field.deconstruct()
+ field_class = import_by_path(path)
+ fields.append((name, field_class(*args, **kwargs)))
# Extract the options
options = {}
for name in DEFAULT_NAMES:
View
4 tests/migrations/test_state.py
@@ -36,6 +36,7 @@ class Meta:
class Book(models.Model):
title = models.CharField(max_length=1000)
author = models.ForeignKey(Author)
+ contributors = models.ManyToManyField(Author)
class Meta:
app_label = "migrations"
@@ -59,9 +60,10 @@ class Meta:
self.assertEqual(book_state.app_label, "migrations")
self.assertEqual(book_state.name, "Book")
- self.assertEqual([x for x, y in book_state.fields], ["id", "title", "author"])
+ self.assertEqual([x for x, y in book_state.fields], ["id", "title", "author", "contributors"])
self.assertEqual(book_state.fields[1][1].max_length, 1000)
self.assertEqual(book_state.fields[2][1].null, False)
+ self.assertEqual(book_state.fields[3][1].__class__.__name__, "ManyToManyField")
self.assertEqual(book_state.options, {"verbose_name": "tome", "db_table": "test_tome"})
self.assertEqual(book_state.bases, (models.Model, ))

0 comments on commit 5e63977

Please sign in to comment.
Something went wrong with that request. Please try again.