Browse files

Fixed #22351 -- Removed usage of lambdas in model field options.

Thanks claudep for review.
  • Loading branch information...
1 parent e167e96 commit 5ebf03b7dd2d1c215f5c0b725083d36379a7ac5b @timgraham timgraham committed Jul 9, 2014
Showing with 13 additions and 3 deletions.
  1. +13 −3 docs/ref/models/fields.txt
16 docs/ref/models/fields.txt
@@ -209,9 +209,16 @@ The default cannot be a mutable object (model instance, list, set, etc.), as a
reference to the same instance of that object would be used as the default
value in all new model instances. Instead, wrap the desired default in a
callable. For example, if you had a custom ``JSONField`` and wanted to specify
-a dictionary as the default, use a ``lambda`` as follows::
+a dictionary as the default, use a function as follows::
- contact_info = JSONField("ContactInfo", default=lambda:{"email": ""})
+ def contact_default():
+ return {"email": ""}
+ contact_info = JSONField("ContactInfo", default=contact_default)
+Note that ``lambda``\s cannot be used for field options like ``default``
+because they cannot be :ref:`serialized by migrations <migration-serializing>`.
+See that documentation for other caveats.
@@ -1101,7 +1108,10 @@ define the details of how the relation works.
with the Python ``datetime`` module to limit selections by date range. For
- limit_choices_to = lambda: {'pub_date__lte':}
+ def limit_pub_date_choices():
+ return {'pub_date__lte':}
+ limit_choices_to = limit_pub_date_choices
If ``limit_choices_to`` is or returns a :class:`Q object
<django.db.models.Q>`, which is useful for :ref:`complex queries

0 comments on commit 5ebf03b

Please sign in to comment.