Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Fixed #8978 -- We now print a helpful error message for 'manage.py db…

…shell' if the client executable is not found. Previously we were displaying a traceback

git-svn-id: http://code.djangoproject.com/svn/django/trunk@8990 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 640f198111fc1e770700a938c43e6df2eff300ca 1 parent 42a878c
Adrian Holovaty authored September 09, 2008
12  django/core/management/commands/dbshell.py
... ...
@@ -1,4 +1,4 @@
1  
-from django.core.management.base import NoArgsCommand
  1
+from django.core.management.base import NoArgsCommand, CommandError
2 2
 
3 3
 class Command(NoArgsCommand):
4 4
     help = "Runs the command-line client for the current DATABASE_ENGINE."
@@ -7,4 +7,12 @@ class Command(NoArgsCommand):
7 7
 
8 8
     def handle_noargs(self, **options):
9 9
         from django.db import connection
10  
-        connection.client.runshell()
  10
+        try:
  11
+            connection.client.runshell()
  12
+        except OSError:
  13
+            # Note that we're assuming OSError means that the client program
  14
+            # isn't installed. There's a possibility OSError would be raised
  15
+            # for some other reason, in which case this error message would be
  16
+            # inaccurate. Still, this message catches the common case.
  17
+            raise CommandError('You appear not to have the %r program installed or on your path.' % \
  18
+                connection.client.executable_name)

0 notes on commit 640f198

Please sign in to comment.
Something went wrong with that request. Please try again.