Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Fixed #21518 -- Made override_settings(ROOT_URLCONF) clear the resolv…

…er cache.

Thanks Aymeric Augustin and Simon Charette for reviews.
  • Loading branch information...
commit 65131911dba08dcc1451d71ae4d5101724d722f6 1 parent 43510cf
@qris qris authored timgraham committed
Showing with 40 additions and 1 deletion.
  1. +7 −0 django/test/signals.py
  2. +33 −1 tests/test_utils/tests.py
View
7 django/test/signals.py
@@ -124,3 +124,10 @@ def complex_setting_changed(**kwargs):
# stacklevel=5 shows the line containing the override_settings call.
warnings.warn("Overriding setting %s can lead to unexpected behaviour."
% kwargs['setting'], stacklevel=5)
+
+
+@receiver(setting_changed)
+def root_urlconf_changed(**kwargs):
+ if kwargs['setting'] == 'ROOT_URLCONF':
+ from django.core.urlresolvers import clear_url_caches
+ clear_url_caches()
View
34 tests/test_utils/tests.py
@@ -3,13 +3,16 @@
import unittest
+from django.conf.urls import patterns, url
+from django.core.urlresolvers import reverse
from django.db import connection
from django.forms import EmailField, IntegerField
from django.http import HttpResponse
from django.template.loader import render_to_string
from django.test import SimpleTestCase, TestCase, skipIfDBFeature, skipUnlessDBFeature
from django.test.html import HTMLParseError, parse_html
-from django.test.utils import CaptureQueriesContext, IgnoreAllDeprecationWarningsMixin
+from django.test.utils import (CaptureQueriesContext,
+ IgnoreAllDeprecationWarningsMixin, override_settings)
from django.utils import six
from .models import Person
@@ -627,3 +630,32 @@ def test_normalizer(self):
suite = make_doctest("test_utils.doctest_output")
failures = unittest.TextTestRunner(stream=six.StringIO()).run(suite)
self.assertEqual(failures.failures, [])
+
+
+# for OverrideSettingsTests
+def fake_view(request):
+ pass
+
+
+class FirstUrls:
+ urlpatterns = patterns('', url(r'first/$', fake_view, name='first'))
+
+
+class SecondUrls:
+ urlpatterns = patterns('', url(r'second/$', fake_view, name='second'))
+
+
+class OverrideSettingsTests(TestCase):
+ """
+ #21518 -- If neither override_settings nor a settings_changed receiver
+ clears the URL cache between tests, then one of these two test methods will
+ fail.
+ """
+
+ @override_settings(ROOT_URLCONF=FirstUrls)
+ def test_first(self):
+ reverse('first')
+
+ @override_settings(ROOT_URLCONF=SecondUrls)
+ def test_second(self):
+ reverse('second')
Please sign in to comment.
Something went wrong with that request. Please try again.