Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Fixed #20530 -- Properly decoded non-ASCII query strings on Python 3.

Thanks mitsuhiko for the report.

This commit just adds a test since the problem was fixed in 8aaca65.
  • Loading branch information...
commit 65b6eff322a4a3331601e111934dee95c090961c 1 parent ff49449
Aymeric Augustin authored September 07, 2013

Showing 1 changed file with 13 additions and 0 deletions. Show diff stats Hide diff stats

  1. 13  tests/handlers/tests.py
13  tests/handlers/tests.py
@@ -41,6 +41,16 @@ def test_bad_path_info(self):
41 41
         response = handler(environ, lambda *a, **k: None)
42 42
         self.assertEqual(response.status_code, 400)
43 43
 
  44
+    def test_non_ascii_query_string(self):
  45
+        """Test that non-ASCII query strings are properly decoded (#20530)."""
  46
+        environ = RequestFactory().get('/').environ
  47
+        raw_query_string = 'want=café'
  48
+        if six.PY3:
  49
+            raw_query_string = raw_query_string.encode('utf-8').decode('iso-8859-1')
  50
+        environ['QUERY_STRING'] = raw_query_string
  51
+        request = WSGIRequest(environ)
  52
+        self.assertEqual(request.GET['want'], "café")
  53
+
44 54
     def test_non_ascii_cookie(self):
45 55
         """Test that non-ASCII cookies set in JavaScript are properly decoded (#20557)."""
46 56
         environ = RequestFactory().get('/').environ
@@ -49,6 +59,9 @@ def test_non_ascii_cookie(self):
49 59
             raw_cookie = raw_cookie.encode('utf-8').decode('iso-8859-1')
50 60
         environ['HTTP_COOKIE'] = raw_cookie
51 61
         request = WSGIRequest(environ)
  62
+        # If would be nicer if request.COOKIES returned unicode values.
  63
+        # However the current cookie parser doesn't do this and fixing it is
  64
+        # much more work than fixing #20557. Feel free to remove force_str()!
52 65
         self.assertEqual(request.COOKIES['want'], force_str("café"))
53 66
 
54 67
 

0 notes on commit 65b6eff

Please sign in to comment.
Something went wrong with that request. Please try again.