Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixed #20530 -- Properly decoded non-ASCII query strings on Python 3.

Thanks mitsuhiko for the report.

This commit just adds a test since the problem was fixed in 8aaca65.
  • Loading branch information...
commit 65b6eff322a4a3331601e111934dee95c090961c 1 parent ff49449
@aaugustin aaugustin authored
Showing with 13 additions and 0 deletions.
  1. +13 −0 tests/handlers/tests.py
View
13 tests/handlers/tests.py
@@ -41,6 +41,16 @@ def test_bad_path_info(self):
response = handler(environ, lambda *a, **k: None)
self.assertEqual(response.status_code, 400)
+ def test_non_ascii_query_string(self):
+ """Test that non-ASCII query strings are properly decoded (#20530)."""
+ environ = RequestFactory().get('/').environ
+ raw_query_string = 'want=café'
+ if six.PY3:
+ raw_query_string = raw_query_string.encode('utf-8').decode('iso-8859-1')
+ environ['QUERY_STRING'] = raw_query_string
+ request = WSGIRequest(environ)
+ self.assertEqual(request.GET['want'], "café")
+
def test_non_ascii_cookie(self):
"""Test that non-ASCII cookies set in JavaScript are properly decoded (#20557)."""
environ = RequestFactory().get('/').environ
@@ -49,6 +59,9 @@ def test_non_ascii_cookie(self):
raw_cookie = raw_cookie.encode('utf-8').decode('iso-8859-1')
environ['HTTP_COOKIE'] = raw_cookie
request = WSGIRequest(environ)
+ # If would be nicer if request.COOKIES returned unicode values.
+ # However the current cookie parser doesn't do this and fixing it is
+ # much more work than fixing #20557. Feel free to remove force_str()!
self.assertEqual(request.COOKIES['want'], force_str("café"))
Please sign in to comment.
Something went wrong with that request. Please try again.