Permalink
Browse files

Fixed #2456 -- Added backslash escaping to addslashes, which is neces…

…sary once

you start escaping other things. Thanks, tom@eggdrop.ch.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@3799 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
1 parent 93597d0 commit 670e8ab7040b3cb1f04d72a76b2c1fc9a4b3f457 @malcolmt malcolmt committed Sep 23, 2006
Showing with 4 additions and 1 deletion.
  1. +1 −1 django/template/defaultfilters.py
  2. +3 −0 tests/regressiontests/defaultfilters/tests.py
@@ -15,7 +15,7 @@
def addslashes(value):
"Adds slashes - useful for passing strings to JavaScript, for example."
- return value.replace('"', '\\"').replace("'", "\\'")
+ return value.replace('\\', '\\\\').replace('"', '\\"').replace("'", "\\'")
def capfirst(value):
"Capitalizes the first character of the value"
@@ -15,6 +15,9 @@
>>> addslashes('"double quotes" and \'single quotes\'')
'\\"double quotes\\" and \\\'single quotes\\\''
+>>> addslashes(r'\ : backslashes, too')
+'\\\\ : backslashes, too'
+
>>> capfirst('hello world')
'Hello world'

0 comments on commit 670e8ab

Please sign in to comment.