Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

[1.6.x] Fixed #21249 -- variable name typo in compiler.get_grouping()

The typo could have consequences in exceptional cases, but I didn't
figure out a way to actually produce such a case, so not tests.

Report & patch by Michael Manfre.

Backport of 86c248a from master
  • Loading branch information...
commit 6781dc624318fd03032efb3182266bae0a5c8fc0 1 parent 86373dc
@akaariai akaariai authored
Showing with 1 addition and 1 deletion.
  1. +1 −1  django/db/models/sql/compiler.py
View
2  django/db/models/sql/compiler.py
@@ -598,7 +598,7 @@ def get_grouping(self, having_group_by, ordering_group_by):
for order, order_params in ordering_group_by:
# Even if we have seen the same SQL string, it might have
# different params, so, we add same SQL in "has params" case.
- if order not in seen or params:
+ if order not in seen or order_params:
result.append(order)
params.extend(order_params)
seen.add(order)
Please sign in to comment.
Something went wrong with that request. Please try again.