Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

[1.2.X] Fixed sending mail on 404s to fail silently.

A failure in the e-mail system should not turn a 404 into a 500.

Backport of [15145] from trunk.

git-svn-id: http://code.djangoproject.com/svn/django/branches/releases/1.2.X@15146 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 6849c5f3d5ed14743fa8f45fb4b2bba027ec9a62 1 parent 0b0e945
@spookylukey spookylukey authored
Showing with 2 additions and 1 deletion.
  1. +2 −1  django/middleware/common.py
View
3  django/middleware/common.py
@@ -94,7 +94,8 @@ def process_response(self, request, response):
ip = request.META.get('REMOTE_ADDR', '<none>')
mail_managers("Broken %slink on %s" % ((is_internal and 'INTERNAL ' or ''), domain),
"Referrer: %s\nRequested URL: %s\nUser agent: %s\nIP address: %s\n" \
- % (referer, request.get_full_path(), ua, ip))
+ % (referer, request.get_full_path(), ua, ip),
+ fail_silently=True)
return response
# Use ETags, if requested.
Please sign in to comment.
Something went wrong with that request. Please try again.