Browse files

[1.5.x] Silenced last sporadic failure on 1.5.

This commit is a last resort; technically the test is correct but our testsuite
has some threading issues when LiveServer is used. Since this will never get
fixed in 1.5 and apperently doesn't get triggered on 1.6 we just make sure the
test doesn't error out. I am not 100% sure why this actually fixes the issue,
but this is still better than having failing builds wheneever we do a security
release for 1.5.

(Tested on jenkins itself, should work (tm)).
  • Loading branch information...
1 parent 3c3b3fc commit 6a708cd654fe63278ea8a14b3e44da847c62ebf4 @apollo13 apollo13 committed Sep 17, 2013
Showing with 6 additions and 0 deletions.
  1. +6 −0 tests/regressiontests/forms/tests/
@@ -1116,6 +1116,12 @@ def test_textarea_trailing_newlines(self):
article = Article.objects.get(
# Should be "\nTst\n" after #19251 is fixed
self.assertEqual(article.content, "\r\nTst\r\n")
+ # So now it's becoming obscure; we do have threading issues here, so this
+ # test fails sometimes for sqlite, I could only ever witness it on jenkins.
+ # As long as 1.5 is supported we manually "fix" this test by quitting
+ # selenium. No idea why closing the browser window isn't enough, but hey…
+ self.selenium.quit()
+ delattr(self.__class__, 'selenium')

0 comments on commit 6a708cd

Please sign in to comment.