Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

newforms: Implemented formfield() for database ForeignKey class and a…

…dded unit tests

git-svn-id: bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 6a75c8a52ef01c680677c13cefb08a9ccbe38562 1 parent d853278
@adrianholovaty adrianholovaty authored
5 django/db/models/fields/
@@ -361,7 +361,7 @@ def _remove_items(self, source_col_name, target_col_name, *objs):
old_ids = set([obj._get_pk_val() for obj in objs])
cursor = connection.cursor()
cursor.execute("DELETE FROM %s WHERE %s = %%s AND %s IN (%s)" % \
- (self.join_table, source_col_name,
+ (self.join_table, source_col_name,
target_col_name, ",".join(['%s'] * len(old_ids))),
[self._pk_val] + list(old_ids))
@@ -548,6 +548,9 @@ def contribute_to_class(self, cls, name):
def contribute_to_related_class(self, cls, related):
setattr(cls, related.get_accessor_name(), ForeignRelatedObjectsDescriptor(related))
+ def formfield(self):
+ return forms.ChoiceField(choices=self.get_choices_default(), required=not self.blank, label=capfirst(self.verbose_name))
class OneToOneField(RelatedField, IntegerField):
def __init__(self, to, to_field=None, **kwargs):
21 tests/modeltests/model_forms/
@@ -20,9 +20,16 @@ class Category(models.Model):
def __str__(self):
+class Writer(models.Model):
+ name = models.CharField(maxlength=50)
+ def __str__(self):
+ return
class Article(models.Model):
headline = models.CharField(maxlength=50)
pub_date = models.DateTimeField()
+ writer = models.ForeignKey(Writer)
categories = models.ManyToManyField(Category)
def __str__(self):
@@ -101,12 +108,24 @@ def __str__(self):
ValueError: The Category could not be created because the data didn't validate.
-ManyToManyFields are represented by a MultipleChoiceField.
+Create a couple of Writers.
+>>> w = Writer(name='Mike Royko')
+>>> w = Writer(name='Bob Woodward')
+ManyToManyFields are represented by a MultipleChoiceField, and ForeignKeys are
+represented by a ChoiceField.
>>> ArticleForm = form_for_model(Article)
>>> f = ArticleForm(auto_id=False)
>>> print f
<tr><th>Headline:</th><td><input type="text" name="headline" maxlength="50" /></td></tr>
<tr><th>Pub date:</th><td><input type="text" name="pub_date" /></td></tr>
+<tr><th>Writer:</th><td><select name="writer">
+<option value="" selected="selected">---------</option>
+<option value="1">Mike Royko</option>
+<option value="2">Bob Woodward</option>
<tr><th>Categories:</th><td><select multiple="multiple" name="categories">
<option value="1">Entertainment</option>
<option value="2">It&#39;s a test</option>
Please sign in to comment.
Something went wrong with that request. Please try again.