Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

[1.0.X] Fixed #9494 -- Ensure the foreign key in an inline formset is…

… always present on the forms. Thanks Fugazi for the report.

Backport of r9326 from trunk

git-svn-id: http://code.djangoproject.com/svn/django/branches/releases/1.0.X@9327 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 6c069d2a71e19955b34a9c5aecc4d2075a5d430a 1 parent da15165
@brosner brosner authored
View
7 django/forms/models.py
@@ -539,6 +539,13 @@ def inlineformset_factory(parent_model, model, form=ModelForm,
# enforce a max_num=1 when the foreign key to the parent model is unique.
if fk.unique:
max_num = 1
+ if fields is not None:
+ fields = list(fields)
+ fields.append(fk.name)
+ else:
+ # get all the fields for this model that will be generated.
+ fields = fields_for_model(model, fields, exclude, formfield_callback).keys()
+ fields.append(fk.name)
kwargs = {
'form': form,
'formfield_callback': formfield_callback,
View
15 tests/modeltests/model_formsets/models.py
@@ -696,6 +696,21 @@ def __unicode__(self):
>>> formset.errors
[{'__all__': [u'Revision with this Repository and Revision already exists.']}]
+# unique_together with inlineformset_factory with overridden form fields
+# Also see #9494
+
+>>> FormSet = inlineformset_factory(Repository, Revision, fields=('revision',), extra=1)
+>>> data = {
+... 'revision_set-TOTAL_FORMS': '1',
+... 'revision_set-INITIAL_FORMS': '0',
+... 'revision_set-0-repository': repository.pk,
+... 'revision_set-0-revision': '146239817507f148d448db38840db7c3cbf47c76',
+... 'revision_set-0-DELETE': '',
+... }
+>>> formset = FormSet(data, instance=repository)
+>>> formset.is_valid()
+False
+
# Use of callable defaults (see bug #7975).
>>> person = Person.objects.create(name='Ringo')
Please sign in to comment.
Something went wrong with that request. Please try again.