Skip to content

Commit

Permalink
Fixed #3664 -- Documented that get_absolute_url() and item_link() (in
Browse files Browse the repository at this point in the history
syndication) links are expected to be strings that can be used in URLs without
further quoting or encoding.


git-svn-id: http://code.djangoproject.com/svn/django/trunk@5250 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information
malcolmt committed May 15, 2007
1 parent a10e73a commit 7969c1b
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
9 changes: 9 additions & 0 deletions docs/model-api.txt
Expand Up @@ -1759,6 +1759,15 @@ But this template code is good::

<a href="{{ object.get_absolute_url }}">{{ object.name }}</a>

.. note::
The string you return from ``get_absolute_url()`` must be use only ASCII
characters (required by the URI spec, `RFC 2396`_) that has been
URL-encoded, if necessary. Code and templates using ``get_absolute_url()``
should be able to use the result directly without needing to do any
further processing.

.. _RFC 2396: http://www.ietf.org/rfc/rfc2396.txt

The ``permalink`` decorator
~~~~~~~~~~~~~~~~~~~~~~~~~~~

Expand Down
5 changes: 4 additions & 1 deletion docs/syndication_feeds.txt
Expand Up @@ -146,7 +146,10 @@ put into those elements.
exist, it tries calling a method ``item_link()`` in the ``Feed`` class,
passing it a single parameter, ``item``, which is the object itself.
Both ``get_absolute_url()`` and ``item_link()`` should return the item's
URL as a normal Python string.
URL as a normal Python string. As with ``get_absolute_url()``, the
result of ``item_link()`` will be included directly in the URL, so you
are responsible for doing all necessary URL quoting and conversion to
ASCII inside the method itself.

* For the LatestEntries example above, we could have very simple feed templates:

Expand Down

0 comments on commit 7969c1b

Please sign in to comment.