Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Fixed #13256 -- `OGRGeometry` no longer raises an exception when comp…

…ared to instances of different types. Thanks, ninowalker for the bug report.

git-svn-id: http://code.djangoproject.com/svn/django/trunk@12905 bcc190cf-cafb-0310-a4f2-bffc1f526a37
  • Loading branch information...
commit 7d5c7df6a943b5659831e4f38546798c7bd541c0 1 parent f7cf58a
Justin Bronn jbronn authored
7 django/contrib/gis/gdal/geometries.py
View
@@ -180,11 +180,14 @@ def __xor__(self, other):
def __eq__(self, other):
"Is this Geometry equal to the other?"
- return self.equals(other)
+ if isinstance(other, OGRGeometry):
+ return self.equals(other)
+ else:
+ return False
def __ne__(self, other):
"Tests for inequality."
- return not self.equals(other)
+ return not (self == other)
def __str__(self):
"WKT is used for the string representation."
5 django/contrib/gis/gdal/tests/test_geom.py
View
@@ -481,6 +481,11 @@ def test18_ogrgeometry_transform_workaround(self):
self.assertEqual(3, geom[0].coord_dim)
self.assertEqual(wkt_3d, geom.wkt)
+ def test19_equivalence_regression(self):
+ "Testing equivalence methods with non-OGRGeometry instances."
+ self.assertNotEqual(None, OGRGeometry('POINT(0 0)'))
+ self.assertEqual(False, OGRGeometry('LINESTRING(0 0, 1 1)') == 3)
+
def suite():
s = unittest.TestSuite()
s.addTest(unittest.makeSuite(OGRGeomTest))
Please sign in to comment.
Something went wrong with that request. Please try again.